[WIP] r/aws_route: Correctly handle update of route target #14050

ewbankkit · 2020-07-05T20:55:29Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #684.
Closes #2270.
Closes #11455.
Closes #12631.
Closes #13302.
Closes #13079.

Uses additional tests cases from #14014.

Includes functionality from #12062.

I will address some similar problems for the aws_route_table (and aws_default_route_table) resources in a separate PR.

Release note for CHANGELOG:

resource/aws_route: Correctly handle updates to the route target attributes (`egress_only_gateway_id`, `gateway_id`, `instance_id`, `nat_gateway_id`, `network_interface_id`, `network_interface_id`, `transit_gateway_id`, `vpc_peering_connection_id`)

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== RUN   TestAccAWSRoute_disappears
=== PAUSE TestAccAWSRoute_disappears
=== RUN   TestAccAWSRoute_routeTableDisappears
=== PAUSE TestAccAWSRoute_routeTableDisappears
=== RUN   TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_InternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_InternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_Instance
=== PAUSE TestAccAWSRoute_IPv6_To_Instance
=== RUN   TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv6_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv6_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv4_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_Instance
=== PAUSE TestAccAWSRoute_IPv4_To_Instance
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
=== RUN   TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv4_To_NatGateway
=== PAUSE TestAccAWSRoute_IPv4_To_NatGateway
=== RUN   TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== RUN   TestAccAWSRoute_IPv4_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv4_To_TransitGateway
=== RUN   TestAccAWSRoute_ConditionalCidrBlock
=== PAUSE TestAccAWSRoute_ConditionalCidrBlock
=== RUN   TestAccAWSRoute_IPv4_Update_Target
=== PAUSE TestAccAWSRoute_IPv4_Update_Target
=== RUN   TestAccAWSRoute_IPv6_Update_Target
=== PAUSE TestAccAWSRoute_IPv6_Update_Target
=== CONT  TestAccAWSRoute_disappears
=== CONT  TestAccAWSRoute_IPv6_Update_Target
--- PASS: TestAccAWSRoute_disappears (48.49s)
=== CONT  TestAccAWSRoute_IPv4_Update_Target
--- PASS: TestAccAWSRoute_IPv6_Update_Target (266.65s)
=== CONT  TestAccAWSRoute_ConditionalCidrBlock
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (76.16s)
=== CONT  TestAccAWSRoute_IPv4_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv4_Update_Target (502.14s)
=== CONT  TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (63.18s)
=== CONT  TestAccAWSRoute_IPv4_To_NatGateway
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (346.35s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (42.93s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (216.48s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (155.89s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (48.44s)
=== CONT  TestAccAWSRoute_IPv4_To_Instance
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (146.10s)
=== CONT  TestAccAWSRoute_IPv4_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (59.08s)
=== CONT  TestAccAWSRoute_IPv6_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_Instance (139.67s)
=== CONT  TestAccAWSRoute_IPv6_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (56.31s)
=== CONT  TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (43.67s)
=== CONT  TestAccAWSRoute_IPv6_To_Instance
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (49.09s)
=== CONT  TestAccAWSRoute_IPv6_To_InternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (52.37s)
=== CONT  TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_Instance (131.22s)
=== CONT  TestAccAWSRoute_routeTableDisappears
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (59.16s)
=== CONT  TestAccAWSRoute_basic
--- PASS: TestAccAWSRoute_routeTableDisappears (48.47s)
--- PASS: TestAccAWSRoute_basic (50.81s)
PASS
ok  github.com/terraform-providers/terraform-provider-aws/aws   1303.322s

ewbankkit · 2020-07-05T20:57:31Z

aws/resource_aws_route.go

+		return fmt.Errorf("error updating Route for Route Table (%s) with destination (%s): %s", routeTableID, destination, err)
+	}
+
+	return resourceAwsRouteRead(d, meta)


Read after Update.

ewbankkit · 2020-07-05T20:58:39Z

aws/data_source_aws_route.go

@@ -190,3 +191,13 @@ func getRoutes(table *ec2.RouteTable, d *schema.ResourceData) []*ec2.Route {
 	}
 	return routes
 }
+


Moved here temporarily. Will need to clean up when support for managed prefix list IDs added.

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_basic -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === CONT TestAccAWSRoute_basic --- PASS: TestAccAWSRoute_basic (53.08s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 53.129s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_disappears' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_disappears -timeout 120m === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_disappears (49.64s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 49.690s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_changeCidr' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_changeCidr -timeout 120m === RUN TestAccAWSRoute_changeCidr === PAUSE TestAccAWSRoute_changeCidr === CONT TestAccAWSRoute_changeCidr --- PASS: TestAccAWSRoute_changeCidr (77.60s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 77.646s

…_ipv6ToEgressOnlyInternetGateway'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_ipv6ToEgressOnlyInternetGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_ipv6ToEgressOnlyInternetGateway -timeout 120m === RUN TestAccAWSRoute_ipv6ToEgressOnlyInternetGateway === PAUSE TestAccAWSRoute_ipv6ToEgressOnlyInternetGateway === CONT TestAccAWSRoute_ipv6ToEgressOnlyInternetGateway --- PASS: TestAccAWSRoute_ipv6ToEgressOnlyInternetGateway (61.15s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 61.206s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_basic -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === CONT TestAccAWSRoute_basic --- PASS: TestAccAWSRoute_basic (52.29s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 52.339s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_changeCidr' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_changeCidr -timeout 120m === RUN TestAccAWSRoute_changeCidr === PAUSE TestAccAWSRoute_changeCidr === CONT TestAccAWSRoute_changeCidr --- PASS: TestAccAWSRoute_changeCidr (78.93s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 79.529s

…nctionality.

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_doesNotCrashWithVPCEndpoint' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_doesNotCrashWithVPCEndpoint -timeout 120m === RUN TestAccAWSRoute_doesNotCrashWithVPCEndpoint === PAUSE TestAccAWSRoute_doesNotCrashWithVPCEndpoint === CONT TestAccAWSRoute_doesNotCrashWithVPCEndpoint --- PASS: TestAccAWSRoute_doesNotCrashWithVPCEndpoint (62.84s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 62.882s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_ipv6ToInternetGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_ipv6ToInternetGateway -timeout 120m === RUN TestAccAWSRoute_ipv6ToInternetGateway === PAUSE TestAccAWSRoute_ipv6ToInternetGateway === CONT TestAccAWSRoute_ipv6ToInternetGateway --- PASS: TestAccAWSRoute_ipv6ToInternetGateway (51.99s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 52.050s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_ipv6ToInstance' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_ipv6ToInstance -timeout 120m === RUN TestAccAWSRoute_ipv6ToInstance === PAUSE TestAccAWSRoute_ipv6ToInstance === CONT TestAccAWSRoute_ipv6ToInstance --- PASS: TestAccAWSRoute_ipv6ToInstance (111.03s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 111.103s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_ipv6ToNetworkInterface' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_ipv6ToNetworkInterface -timeout 120m === RUN TestAccAWSRoute_ipv6ToNetworkInterface === PAUSE TestAccAWSRoute_ipv6ToNetworkInterface === CONT TestAccAWSRoute_ipv6ToNetworkInterface --- PASS: TestAccAWSRoute_ipv6ToNetworkInterface (47.92s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 47.969s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_ipv6ToVpcPeeringConnection' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_ipv6ToVpcPeeringConnection -timeout 120m === RUN TestAccAWSRoute_ipv6ToVpcPeeringConnection === PAUSE TestAccAWSRoute_ipv6ToVpcPeeringConnection === CONT TestAccAWSRoute_ipv6ToVpcPeeringConnection --- PASS: TestAccAWSRoute_ipv6ToVpcPeeringConnection (44.00s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 44.054s

…rBlock' and rename tests. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRoute_IPv6_To_InternetGateway === PAUSE TestAccAWSRoute_IPv6_To_InternetGateway === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === RUN TestAccAWSRoute_IPv6_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface === RUN TestAccAWSRoute_IPv6_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_InternetGateway === PAUSE TestAccAWSRoute_IPv4_To_InternetGateway === RUN TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === RUN TestAccAWSRoute_IPv4_To_TransitGateway === PAUSE TestAccAWSRoute_IPv4_To_TransitGateway === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === CONT TestAccAWSRoute_basic === CONT TestAccAWSRoute_IPv6_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (42.94s) === CONT TestAccAWSRoute_ConditionalCidrBlock --- PASS: TestAccAWSRoute_basic (51.95s) === CONT TestAccAWSRoute_IPv4_To_TransitGateway --- PASS: TestAccAWSRoute_ConditionalCidrBlock (76.30s) === CONT TestAccAWSRoute_DoesNotCrashWithVpcEndpoint --- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (61.41s) === CONT TestAccAWSRoute_IPv4_To_InternetGateway --- PASS: TestAccAWSRoute_IPv4_To_InternetGateway (76.58s) === CONT TestAccAWSRoute_IPv6_To_InternetGateway --- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (53.22s) === CONT TestAccAWSRoute_IPv6_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface (47.85s) === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (315.51s) === CONT TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (59.04s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_disappears (47.96s) --- PASS: TestAccAWSRoute_IPv6_To_Instance (129.66s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 488.049s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_Instance' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_Instance -timeout 120m === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_Instance (87.65s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 87.699s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_NetworkInterface' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_NetworkInterface -timeout 120m === RUN TestAccAWSRoute_IPv4_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface === CONT TestAccAWSRoute_IPv4_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface (47.04s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 47.100s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_VpcPeeringConnection' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_VpcPeeringConnection -timeout 120m === RUN TestAccAWSRoute_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection === CONT TestAccAWSRoute_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (42.88s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 42.928s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_NatGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_NatGateway -timeout 120m === RUN TestAccAWSRoute_IPv4_To_NatGateway === PAUSE TestAccAWSRoute_IPv4_To_NatGateway === CONT TestAccAWSRoute_IPv4_To_NatGateway --- PASS: TestAccAWSRoute_IPv4_To_NatGateway (195.61s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 195.647s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 1 -run=TestAccAWSRoute_ -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRoute_IPv6_To_InternetGateway === PAUSE TestAccAWSRoute_IPv6_To_InternetGateway === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === RUN TestAccAWSRoute_IPv6_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface === RUN TestAccAWSRoute_IPv6_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_InternetGateway === PAUSE TestAccAWSRoute_IPv4_To_InternetGateway === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === RUN TestAccAWSRoute_IPv4_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface === RUN TestAccAWSRoute_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_NatGateway === PAUSE TestAccAWSRoute_IPv4_To_NatGateway === RUN TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === RUN TestAccAWSRoute_IPv4_To_TransitGateway === PAUSE TestAccAWSRoute_IPv4_To_TransitGateway === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === CONT TestAccAWSRoute_basic --- PASS: TestAccAWSRoute_basic (52.44s) === CONT TestAccAWSRoute_ConditionalCidrBlock --- PASS: TestAccAWSRoute_ConditionalCidrBlock (76.36s) === CONT TestAccAWSRoute_IPv4_To_TransitGateway --- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (358.76s) === CONT TestAccAWSRoute_DoesNotCrashWithVpcEndpoint --- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (62.15s) === CONT TestAccAWSRoute_IPv4_To_NatGateway --- PASS: TestAccAWSRoute_IPv4_To_NatGateway (195.36s) === CONT TestAccAWSRoute_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (43.17s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface (46.84s) === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_Instance (120.01s) === CONT TestAccAWSRoute_IPv4_To_InternetGateway --- PASS: TestAccAWSRoute_IPv4_To_InternetGateway (77.57s) === CONT TestAccAWSRoute_IPv6_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (42.36s) === CONT TestAccAWSRoute_IPv6_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface (48.01s) === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv6_To_Instance (119.62s) === CONT TestAccAWSRoute_IPv6_To_InternetGateway --- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (51.75s) === CONT TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (58.58s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_disappears (47.56s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1400.609s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_VpnGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_VpnGateway -timeout 120m === RUN TestAccAWSRoute_IPv4_To_VpnGateway === PAUSE TestAccAWSRoute_IPv4_To_VpnGateway === CONT TestAccAWSRoute_IPv4_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (63.35s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 63.423s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv6_To_VpnGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv6_To_VpnGateway -timeout 120m === RUN TestAccAWSRoute_IPv6_To_VpnGateway === PAUSE TestAccAWSRoute_IPv6_To_VpnGateway === CONT TestAccAWSRoute_IPv6_To_VpnGateway --- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (56.25s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 56.281s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRoute_IPv6_To_InternetGateway === PAUSE TestAccAWSRoute_IPv6_To_InternetGateway === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === RUN TestAccAWSRoute_IPv6_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface === RUN TestAccAWSRoute_IPv6_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv6_To_VpnGateway === PAUSE TestAccAWSRoute_IPv6_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_VpnGateway === PAUSE TestAccAWSRoute_IPv4_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === RUN TestAccAWSRoute_IPv4_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface === RUN TestAccAWSRoute_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_NatGateway === PAUSE TestAccAWSRoute_IPv4_To_NatGateway === RUN TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === RUN TestAccAWSRoute_IPv4_To_TransitGateway === PAUSE TestAccAWSRoute_IPv4_To_TransitGateway === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === CONT TestAccAWSRoute_basic === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_basic (52.59s) === CONT TestAccAWSRoute_ConditionalCidrBlock --- PASS: TestAccAWSRoute_ConditionalCidrBlock (76.45s) === CONT TestAccAWSRoute_IPv4_To_TransitGateway --- PASS: TestAccAWSRoute_IPv4_To_Instance (129.99s) === CONT TestAccAWSRoute_DoesNotCrashWithVpcEndpoint --- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (63.26s) === CONT TestAccAWSRoute_IPv4_To_NatGateway --- PASS: TestAccAWSRoute_IPv4_To_NatGateway (205.43s) === CONT TestAccAWSRoute_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (43.54s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface (33.36s) === CONT TestAccAWSRoute_IPv6_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (347.29s) === CONT TestAccAWSRoute_IPv4_To_VpnGateway --- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface (33.84s) === CONT TestAccAWSRoute_IPv6_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (55.26s) === CONT TestAccAWSRoute_IPv6_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (62.51s) === CONT TestAccAWSRoute_IPv6_To_InternetGateway --- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (42.95s) === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (52.13s) === CONT TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (59.35s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_IPv6_To_Instance (119.68s) --- PASS: TestAccAWSRoute_disappears (48.50s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 731.979s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_routeTableDisappears' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_routeTableDisappears -timeout 120m === RUN TestAccAWSRoute_routeTableDisappears === PAUSE TestAccAWSRoute_routeTableDisappears === CONT TestAccAWSRoute_routeTableDisappears --- PASS: TestAccAWSRoute_routeTableDisappears (48.84s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 48.910s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_ConditionalCidrBlock' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_ConditionalCidrBlock -timeout 120m === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === CONT TestAccAWSRoute_ConditionalCidrBlock --- PASS: TestAccAWSRoute_ConditionalCidrBlock (76.68s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 76.752s

…to test route to ENI attached to an instance. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_NetworkInterface_Attached' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_NetworkInterface_Attached -timeout 120m === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Attached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (113.54s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 113.607s

…ents' to test route to 2 ENIs attached to the same instance (hashicorp#2270). Acceptance test output (failure expected): $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments -timeout 120m === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments --- FAIL: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (127.29s) testing.go:684: Step 1 error: errors during apply: Error: InvalidInstanceID: There are multiple interfaces attached to instance 'i-005065eb4850f01a4'. Please specify an interface ID for the operation instead. status code: 400, request id: f601a6af-729a-4830-835b-be8887b0c3ee on /tmp/tf-test358593801/main.tf line 98: (source code not available) FAIL FAIL github.com/terraform-providers/terraform-provider-aws/aws 127.347s FAIL GNUmakefile:26: recipe for target 'testacc' failed make: *** [testacc] Error 1

…rface_TwoAttachments'.

…es' data source.

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv6_Update_Target' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv6_Update_Target -timeout 120m === RUN TestAccAWSRoute_IPv6_Update_Target === PAUSE TestAccAWSRoute_IPv6_Update_Target === CONT TestAccAWSRoute_IPv6_Update_Target --- FAIL: TestAccAWSRoute_IPv6_Update_Target (152.32s) testing.go:684: Step 1 error: errors during apply: Error: Error: more than 1 target specified. Only 1 of gateway_id, egress_only_gateway_id, nat_gateway_id, instance_id, network_interface_id or vpc_peering_connection_id is allowed. on /tmp/tf-test007003987/main.tf line 131: (source code not available) FAIL FAIL github.com/terraform-providers/terraform-provider-aws/aws 152.371s FAIL GNUmakefile:26: recipe for target 'testacc' failed make: *** [testacc] Error 1

Acceptance test output (failures expected): $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_routeTableDisappears === PAUSE TestAccAWSRoute_routeTableDisappears === RUN TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRoute_IPv6_To_InternetGateway === PAUSE TestAccAWSRoute_IPv6_To_InternetGateway === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === RUN TestAccAWSRoute_IPv6_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface === RUN TestAccAWSRoute_IPv6_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv6_To_VpnGateway === PAUSE TestAccAWSRoute_IPv6_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_VpnGateway === PAUSE TestAccAWSRoute_IPv4_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === RUN TestAccAWSRoute_IPv4_To_NetworkInterface === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface === RUN TestAccAWSRoute_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_NatGateway === PAUSE TestAccAWSRoute_IPv4_To_NatGateway === RUN TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === RUN TestAccAWSRoute_IPv4_To_TransitGateway === PAUSE TestAccAWSRoute_IPv4_To_TransitGateway === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === RUN TestAccAWSRoute_IPv4_Update_Target === PAUSE TestAccAWSRoute_IPv4_Update_Target === RUN TestAccAWSRoute_IPv6_Update_Target === PAUSE TestAccAWSRoute_IPv6_Update_Target === CONT TestAccAWSRoute_basic === CONT TestAccAWSRoute_IPv6_Update_Target --- PASS: TestAccAWSRoute_basic (52.56s) === CONT TestAccAWSRoute_IPv4_Update_Target --- FAIL: TestAccAWSRoute_IPv6_Update_Target (101.24s) testing.go:684: Step 1 error: errors during apply: Error: Error: more than 1 target specified. Only 1 of gateway_id, egress_only_gateway_id, nat_gateway_id, instance_id, network_interface_id or vpc_peering_connection_id is allowed. on /tmp/tf-test041809885/main.tf line 131: (source code not available) === CONT TestAccAWSRoute_ConditionalCidrBlock --- PASS: TestAccAWSRoute_ConditionalCidrBlock (77.26s) === CONT TestAccAWSRoute_IPv4_To_TransitGateway --- FAIL: TestAccAWSRoute_IPv4_Update_Target (370.49s) testing.go:684: Step 1 error: errors during apply: Error: Error: more than 1 target specified. Only 1 of gateway_id, egress_only_gateway_id, nat_gateway_id, instance_id, network_interface_id or vpc_peering_connection_id is allowed. on /tmp/tf-test640007973/main.tf line 153: (source code not available) === CONT TestAccAWSRoute_DoesNotCrashWithVpcEndpoint --- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (62.59s) === CONT TestAccAWSRoute_IPv4_To_NatGateway --- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (357.58s) === CONT TestAccAWSRoute_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (42.14s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface (48.03s) === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_NatGateway (205.87s) === CONT TestAccAWSRoute_IPv4_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_Instance (97.35s) === CONT TestAccAWSRoute_IPv6_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (53.36s) === CONT TestAccAWSRoute_IPv6_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (62.11s) === CONT TestAccAWSRoute_IPv6_To_NetworkInterface --- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (41.51s) === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface (48.70s) === CONT TestAccAWSRoute_IPv6_To_InternetGateway --- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (52.58s) === CONT TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRoute_IPv6_To_Instance (119.70s) === CONT TestAccAWSRoute_routeTableDisappears --- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (60.46s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_routeTableDisappears (48.52s) --- PASS: TestAccAWSRoute_disappears (47.95s) FAIL FAIL github.com/terraform-providers/terraform-provider-aws/aws 995.477s FAIL GNUmakefile:26: recipe for target 'testacc' failed make: *** [testacc] Error 1

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_Update_Target' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSRoute_IPv4_Update_Target -timeout 120m === RUN TestAccAWSRoute_IPv4_Update_Target === PAUSE TestAccAWSRoute_IPv4_Update_Target === CONT TestAccAWSRoute_IPv4_Update_Target --- PASS: TestAccAWSRoute_IPv4_Update_Target (495.57s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 495.621s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv6_Update_Target' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSRoute_IPv6_Update_Target -timeout 120m === RUN TestAccAWSRoute_IPv6_Update_Target === PAUSE TestAccAWSRoute_IPv6_Update_Target === CONT TestAccAWSRoute_IPv6_Update_Target --- PASS: TestAccAWSRoute_IPv6_Update_Target (246.11s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 246.176s

…oAttachments'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments -timeout 120m === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (145.48s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 145.537s

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_routeTableDisappears === PAUSE TestAccAWSRoute_routeTableDisappears === RUN TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRoute_IPv6_To_InternetGateway === PAUSE TestAccAWSRoute_IPv6_To_InternetGateway === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === RUN TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached === PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached === RUN TestAccAWSRoute_IPv6_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv6_To_VpnGateway === PAUSE TestAccAWSRoute_IPv6_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_VpnGateway === PAUSE TestAccAWSRoute_IPv4_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === RUN TestAccAWSRoute_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_NatGateway === PAUSE TestAccAWSRoute_IPv4_To_NatGateway === RUN TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === RUN TestAccAWSRoute_IPv4_To_TransitGateway === PAUSE TestAccAWSRoute_IPv4_To_TransitGateway === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === RUN TestAccAWSRoute_IPv4_Update_Target === PAUSE TestAccAWSRoute_IPv4_Update_Target === RUN TestAccAWSRoute_IPv6_Update_Target === PAUSE TestAccAWSRoute_IPv6_Update_Target === CONT TestAccAWSRoute_disappears === CONT TestAccAWSRoute_IPv6_Update_Target --- PASS: TestAccAWSRoute_disappears (48.49s) === CONT TestAccAWSRoute_IPv4_Update_Target --- PASS: TestAccAWSRoute_IPv6_Update_Target (266.65s) === CONT TestAccAWSRoute_ConditionalCidrBlock --- PASS: TestAccAWSRoute_ConditionalCidrBlock (76.16s) === CONT TestAccAWSRoute_IPv4_To_TransitGateway --- PASS: TestAccAWSRoute_IPv4_Update_Target (502.14s) === CONT TestAccAWSRoute_DoesNotCrashWithVpcEndpoint --- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (63.18s) === CONT TestAccAWSRoute_IPv4_To_NatGateway --- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (346.35s) === CONT TestAccAWSRoute_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (42.93s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments --- PASS: TestAccAWSRoute_IPv4_To_NatGateway (216.48s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Attached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (155.89s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (48.44s) === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (146.10s) === CONT TestAccAWSRoute_IPv4_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (59.08s) === CONT TestAccAWSRoute_IPv6_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_Instance (139.67s) === CONT TestAccAWSRoute_IPv6_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (56.31s) === CONT TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached --- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (43.67s) === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (49.09s) === CONT TestAccAWSRoute_IPv6_To_InternetGateway --- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (52.37s) === CONT TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRoute_IPv6_To_Instance (131.22s) === CONT TestAccAWSRoute_routeTableDisappears --- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (59.16s) === CONT TestAccAWSRoute_basic --- PASS: TestAccAWSRoute_routeTableDisappears (48.47s) --- PASS: TestAccAWSRoute_basic (50.81s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1303.322s

…es' data source.

…rt a local route. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_LocalRoute' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_LocalRoute -timeout 120m === RUN TestAccAWSRoute_LocalRoute === PAUSE TestAccAWSRoute_LocalRoute === CONT TestAccAWSRoute_LocalRoute --- PASS: TestAccAWSRoute_LocalRoute (38.20s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 38.270s

… route read function names. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_basic -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === CONT TestAccAWSRoute_basic --- PASS: TestAccAWSRoute_basic (51.24s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 51.288s make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_disappears' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_disappears -timeout 120m === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_disappears (47.70s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 47.760s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_disappears' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_disappears -timeout 120m === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_disappears (47.70s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 47.760s

…. Add 'aws/internal/net/cidr.go'.

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_basic -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === CONT TestAccAWSRoute_basic --- PASS: TestAccAWSRoute_basic (51.48s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 51.542s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv6_To_Instance' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv6_To_Instance -timeout 120m === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv6_To_Instance (128.20s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 128.262s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_Instance' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_Instance -timeout 120m === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_Instance (116.72s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 116.766s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_NetworkInterface_Attached' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRoute_IPv4_To_NetworkInterface_Attached -timeout 120m === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Attached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (330.31s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 330.352s

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_routeTableDisappears === PAUSE TestAccAWSRoute_routeTableDisappears === RUN TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRoute_IPv6_To_InternetGateway === PAUSE TestAccAWSRoute_IPv6_To_InternetGateway === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === RUN TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached === PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached === RUN TestAccAWSRoute_IPv6_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv6_To_VpnGateway === PAUSE TestAccAWSRoute_IPv6_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_VpnGateway === PAUSE TestAccAWSRoute_IPv4_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === RUN TestAccAWSRoute_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_NatGateway === PAUSE TestAccAWSRoute_IPv4_To_NatGateway === RUN TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === RUN TestAccAWSRoute_IPv4_To_TransitGateway === PAUSE TestAccAWSRoute_IPv4_To_TransitGateway === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === RUN TestAccAWSRoute_IPv4_Update_Target === PAUSE TestAccAWSRoute_IPv4_Update_Target === RUN TestAccAWSRoute_IPv6_Update_Target === PAUSE TestAccAWSRoute_IPv6_Update_Target === RUN TestAccAWSRoute_LocalRoute === PAUSE TestAccAWSRoute_LocalRoute === CONT TestAccAWSRoute_basic === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Attached --- PASS: TestAccAWSRoute_basic (51.10s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (46.24s) === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (132.44s) === CONT TestAccAWSRoute_IPv4_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (56.29s) === CONT TestAccAWSRoute_IPv6_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_Instance (127.96s) === CONT TestAccAWSRoute_IPv6_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (59.39s) === CONT TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached --- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (41.27s) === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (46.93s) === CONT TestAccAWSRoute_IPv6_To_InternetGateway --- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (51.54s) === CONT TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (57.61s) === CONT TestAccAWSRoute_routeTableDisappears --- PASS: TestAccAWSRoute_routeTableDisappears (47.39s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_disappears (46.70s) === CONT TestAccAWSRoute_IPv4_To_TransitGateway --- PASS: TestAccAWSRoute_IPv6_To_Instance (326.82s) === CONT TestAccAWSRoute_LocalRoute --- PASS: TestAccAWSRoute_LocalRoute (37.26s) === CONT TestAccAWSRoute_IPv6_Update_Target --- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (355.67s) === CONT TestAccAWSRoute_IPv4_Update_Target --- PASS: TestAccAWSRoute_IPv6_Update_Target (272.71s) === CONT TestAccAWSRoute_ConditionalCidrBlock --- PASS: TestAccAWSRoute_ConditionalCidrBlock (75.84s) === CONT TestAccAWSRoute_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (41.56s) === CONT TestAccAWSRoute_DoesNotCrashWithVpcEndpoint --- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (60.36s) === CONT TestAccAWSRoute_IPv4_To_NatGateway --- PASS: TestAccAWSRoute_IPv4_To_NatGateway (224.40s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments --- PASS: TestAccAWSRoute_IPv4_Update_Target (539.79s) --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (174.29s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1479.901s

ewbankkit · 2020-08-09T22:49:55Z

Replaced by #14531. Easier than dealing with a rebase nightmare...

ghost · 2020-09-09T17:10:25Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit requested a review from a team July 5, 2020 20:55

ghost added size/XXL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 5, 2020

ewbankkit commented Jul 5, 2020

View reviewed changes

ewbankkit mentioned this pull request Jul 5, 2020

[WIP] Update 'aws_route' to handle changes in IPv6 route entries #12062

Closed

ewbankkit force-pushed the b-various-aws_route-fixes branch from 483ab37 to 65cecb3 Compare July 6, 2020 20:26

ewbankkit mentioned this pull request Jul 8, 2020

Error creating route: RouteAlreadyExists #11455

Closed

ewbankkit force-pushed the b-various-aws_route-fixes branch 2 times, most recently from a431989 to 662e1e5 Compare July 8, 2020 22:24

ewbankkit changed the title ~~r/aws_route: Correctly handle update of route target~~ [WIP] r/aws_route: Correctly handle update of route target Jul 10, 2020

ewbankkit added 18 commits July 10, 2020 11:03

Remove 'TestAccAWSRoute_noopdiff'. Test steps implicitly test this fu…

4e2bfc8

…nctionality.

r/aws_route: Test computed attributes.

f375bd9

ewbankkit added 15 commits July 10, 2020 11:03

r/aws_route: Comment out failing 'TestAccAWSRoute_IPv4_To_NetworkInte…

9fb69bd

…rface_TwoAttachments'.

r/aws_route: Use 'available' as the name of the 'aws_availability_zon…

a86e680

…es' data source.

r/aws_route: Add 'TestAccAWSRoute_IPv4_Update_Target'. Currently fails.

bc9a711

r/aws_route: Use 'available' as the name of the 'aws_availability_zon…

ea1ec72

…es' data source.

ewbankkit force-pushed the b-various-aws_route-fixes branch from 662e1e5 to 722afda Compare July 10, 2020 15:40

ewbankkit added 4 commits July 10, 2020 14:08

r/aw3s_route: Move route finders to 'aws/internal/service/ec2/finder'…

b2b4fc2

…. Add 'aws/internal/net/cidr.go'.

ewbankkit mentioned this pull request Jul 15, 2020

aws_route/aws_route_table: Remove 'instance_id' target #14197

Closed

anGie44 force-pushed the master branch from 54db70d to 48ba2f7 Compare July 21, 2020 18:26

ewbankkit mentioned this pull request Aug 9, 2020

r/aws_route: Correctly handle update of route target #14531

Closed

ewbankkit closed this Aug 9, 2020

ewbankkit deleted the b-various-aws_route-fixes branch August 9, 2020 22:50

ewbankkit mentioned this pull request Aug 23, 2020

r/aws_route: Correctly handle update of route target #14796

Closed

ewbankkit mentioned this pull request Sep 6, 2020

[WIP] r/aws_route: Correctly handle update of route target #15049

Closed

ghost locked and limited conversation to collaborators Sep 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] r/aws_route: Correctly handle update of route target #14050

[WIP] r/aws_route: Correctly handle update of route target #14050

ewbankkit commented Jul 5, 2020 •

edited

Loading

ewbankkit Jul 5, 2020

ewbankkit Jul 5, 2020

ewbankkit commented Aug 9, 2020

ghost commented Sep 9, 2020

[WIP] r/aws_route: Correctly handle update of route target #14050

[WIP] r/aws_route: Correctly handle update of route target #14050

Conversation

ewbankkit commented Jul 5, 2020 • edited Loading

Community Note

ewbankkit Jul 5, 2020

Choose a reason for hiding this comment

ewbankkit Jul 5, 2020

Choose a reason for hiding this comment

ewbankkit commented Aug 9, 2020

ghost commented Sep 9, 2020

ewbankkit commented Jul 5, 2020 •

edited

Loading